Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize srcLink to Unix style path #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobiasweibel
Copy link

Basically to support Windows build systems.

@OriR
Copy link
Owner

OriR commented Mar 12, 2018

Sorry for the late response!
I'm working on a new version that includes some sort of an "addon" mechanism to hook into custom handlers in react-docgen.
I'll see what I can do to incorporate this into the next version 👍

@OriR
Copy link
Owner

OriR commented Apr 6, 2018

@tobiasweibel I've thought about it some more and srcLink and the new srcLinkUrl I'm adding in the new version should solve this issue.
srcLink is how the path looks in the build system but srcLinkUrl is the actual url to the source therefore I added .replace(/\\/g, '/') to it.

You can look here at the changes here.
Let me know if that's enough 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants